-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Fix fixed cost description for Application Gateway V2 #127592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As we confirmed , no matter AppGW stoped or started, the public IP still be charged by time. so this contents need to be modify.
|
@Tanharuki : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 90ee94e: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the description of fixed costs for Application Gateway V2 to accurately reflect that public IP address charges are billed separately and not included in the gateway's fixed costs.
Key Change:
- Updated the fixed cost documentation to clarify that public IP address costs are separate from Application Gateway V2 fixed costs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - **Fixed costs**: These costs are based on the time the Application Gateway V2 or WAF V2 is provisioned and available for processing requests. This ensures high availability. There's an associated cost even if zero instances are reserved by specifying `0` in the minimum instance count, as part of autoscaling. | ||
| - The fixed cost also includes the cost associated with the public IP address attached to the application gateway. | ||
| - The fixed cost does not includes the cost associated with the public IP address attached to the application gateway. |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical error: 'does not includes' should be 'does not include' (singular form after 'does not').
| - The fixed cost does not includes the cost associated with the public IP address attached to the application gateway. | |
| - The fixed cost does not include the cost associated with the public IP address attached to the application gateway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add fix to PR. Thanks!
|
|
||
| - **Fixed costs**: These costs are based on the time the Application Gateway V2 or WAF V2 is provisioned and available for processing requests. This ensures high availability. There's an associated cost even if zero instances are reserved by specifying `0` in the minimum instance count, as part of autoscaling. | ||
| - The fixed cost also includes the cost associated with the public IP address attached to the application gateway. | ||
| - The fixed cost does not includes the cost associated with the public IP address attached to the application gateway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - The fixed cost does not includes the cost associated with the public IP address attached to the application gateway. | |
| - The fixed cost does not include the cost associated with the public IP address attached to the application gateway. |
Please commit update and then this can be signed off @Tanharuki. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tanharuki - Can you respond to the requested changes or let us know if you would like us to commit them?
@mbender-ms - When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team
As we confirmed , no matter AppGW stoped or started, the public IP still be charged by time. so this contents need to be modify.
"The fixed cost also includes the cost associated with the public IP address attached to the application gateway."
should be "The fixed cost dose not includes the cost associated with the public IP address attached to the application gateway."